redsync.go icon indicating copy to clipboard operation
redsync.go copied to clipboard

Published 20 hours ago • verified publisher icon hjr265

Build Failing

Open mattnenterprise opened this issue 8 years ago • 4 comments

The build is currently failing. Looks like tests aren't passing

mattnenterprise avatar Jan 29 '16 16:01 mattnenterprise

@mattnenterprise Sorry for the late response.

I am actually in the process of redoing this package with a cleaner API and better tests: https://github.com/redsync/redsync/tree/develop

I will also look into the this current package soon and try to figure out what is wrong. The odd part is the test passes on my primary machine, but almost nowhere else.

hjr265 avatar Feb 02 '16 05:02 hjr265

I'm interested in using redsync but am worried about the failing build. Is there any timeline to merge the develop branch? Please let me know if there's anything I can do to help expedite the process.

bfallik avatar Feb 04 '16 20:02 bfallik

@mattnenterprise @bfallik It seems the tests were failing due to some change in the tempredis package that was being used to spin up Redis instances for running the tests. I have pushed a fix and tests are now passing: https://drone.io/github.com/hjr265/redsync.go/17

I will still continue working on the new package and eventually deprecate this. But that might take a while as there are a number of suggestions that I am taking into account.

hjr265 avatar Feb 05 '16 05:02 hjr265

@hjr265 great, thanks!

bfallik avatar Feb 05 '16 15:02 bfallik