CryptoNews icon indicating copy to clipboard operation
CryptoNews copied to clipboard

Published 20 hours ago • verified publisher icon hjoshi123

Mess in sending requests

Open gordinmitya opened this issue 6 years ago • 1 comments

You call loadJSON twice: in onCreate and onStart, what is the sense to do that?

The same problem with compositeDisposable – you call it in onStop as well as in onDestroy.

Another thing that there is no any care about configuration changes.

It would be great if you describe reasons or fix problems in project to not confuse readers! Thank you in advance!

gordinmitya avatar Sep 24 '18 12:09 gordinmitya

Hey @gordinmitya thanks for the issue. It would be awesome if you could create a PR for the above issue. I would be happy to review it and approve it if its necessary.

hjoshi123 avatar Sep 24 '18 12:09 hjoshi123