David J. Hamilton comments

Results 58 comments of


                                            David J. Hamilton

will-destroy does not invoke re-rendering

@pzuraq see https://github.com/emberjs/ember-render-modifiers/pull/19#issuecomment-566763245

Deprecate eager transformValue in favor of computeAttribute

@betocantu93 awesome, thanks for taking this on. I'm very excited to see this evolution -- I think it will make the overall system more flexible and also have a simpler...

Some questions about adapters and serializers

Thanks for raising these questions @betocantu93. This is definitely something that can be clarified in the docs. Out of the box `ember-m3` does not have a strong opinion on your...

debugJSON doesn't work for projections

basically some changes like ```js // model.js debugJSON() { return recordDataFor(this)._debugJSON(); } // record-data.js _debugJSON() { if(this._baseRecordData) { return this._baseRecordData._debugJSON(); } return this._data; } ```

use schemainterface over passing in value to schema API

should get rid of ~~`resolvePlainArray`~~ `isAttributeArrayReference`at the same time and have `computeAttributeReference` return an array of references here. For symmetry `computeNestedModel` should be able to return arrays

resolveValue can erroneously treat nested models as new

In particular this will cause the nested model fields to appear in `changedAttributes()`

resolveValue can erroneously treat nested models as new

@igorT is this still an issue?

`createRecord` changes not flushed if response payload does not have `included`

same problem on `updateRecord` and for the same reason cc @runspired

easier transformValue overriding

@betocantu93 thanks for digging in to this. The current PR implementation adds a couple of `_fn` extension points: we should stick to the convention of treating functions with a leading...

easier transformValue overriding

I'm very +1 on having a smaller API surface area via `computeAttribute`, and providing that function more context, especially indirectly via `schemaInterface`. For top model access maybe something like ```...