kube-downscaler icon indicating copy to clipboard operation
kube-downscaler copied to clipboard

Add events to deployment when action is taken

Open gregsidelinger opened this issue 5 years ago • 3 comments

It would be nice if an event was generated each time a deployment was scaled up/down.

gregsidelinger avatar Jan 08 '20 19:01 gregsidelinger

I was looking into adding this as a feature and it turns out pykube does not have some of the data needed to bind the events to the resource. It is missing the uid and resourceVersion. Since pykube is no longer being developed is there any chance the controller will be moving to the kubernetes python client?

gregsidelinger avatar Feb 14 '20 08:02 gregsidelinger

@gregsidelinger that's not an issue with pykube-ng which I maintain. I also generate events in kube-janitor.

hjacobs avatar Feb 14 '20 11:02 hjacobs

my bad. I did not realize the uid was under metadata. I will send a patch some time this weekend.

gregsidelinger avatar Feb 14 '20 20:02 gregsidelinger