quark-shaders icon indicating copy to clipboard operation
quark-shaders copied to clipboard

crt-royale-xm29plus

Open Max833 opened this issue 4 years ago • 7 comments

Hello, thanks for your efforts. Amazing shader collection! :D

I would like to use crt-royale-xm29plus with bsnes. Is there a quark-shader for this as well?

Max833 avatar Jul 11 '21 17:07 Max833

There is not. It shouldn't be terribly hard to add it, but each one of the royale duplicates adds many MBs to the repo size, so I'm reluctant to add too many. I would also need to port over the color grading LUT shader.

hizzlekizzle avatar Jul 11 '21 18:07 hizzlekizzle

Thank you for your quick reply! I see. That's a shame, but i totally understand.

I have to more questions regarding the quark-shader crt-royale (with bsnes):

  • How can I disable this TV screen bulge/curve effect?

  • No matter if I use fullscreen or pseudo-fullscreen mode, something doesn't look right there, it shows a really weird rainbow effect. Do you know how I can fix this? crt-royale-kurozumi works perfectly, though.

window mode: 1

fullscreen: 2

Max833 avatar Jul 11 '21 18:07 Max833

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

hizzlekizzle avatar Jul 12 '21 18:07 hizzlekizzle

Hmm, looks like the mask is getting scaled some in fullscreen. I'll try to reproduce it and see if I can find a solution.

I think I know what's the reason for that. As soon as I enable aspect correction / overscan and go to the fullscreen mode, this is happening. Is it disabled, everything looks fine. I hope there is a way to fix this. Thank you so much that you are looking at this problem.

For the bulge, you can disable it in the settings, which are at the top of each shader pass. I think for this one, you just need the 'geom mode' set to 0 in the last pass: https://github.com/hizzlekizzle/quark-shaders/blob/master/CRT-Royale.shader/geometry-aa-last-pass.fs#L73

Thank you! It is working. :D

Max833 avatar Jul 13 '21 16:07 Max833

Maybe this commit broke something for some shaders:

https://github.com/bsnes-emu/bsnes/commit/d9f80db0368a9ff8ec5c8c8fe5bf70a42d70c098

Max833 avatar Jul 14 '21 21:07 Max833

that's certainly possible. Can you compile before that commit and see?

hizzlekizzle avatar Jul 14 '21 23:07 hizzlekizzle

Yes, right now. But it didn't affect this...

Edit: Okay, that's why: ^^;

"target-libretro/libretro.cpp"

Max833 avatar Jul 15 '21 20:07 Max833