https-everywhere-checker icon indicating copy to clipboard operation
https-everywhere-checker copied to clipboard

(Possibly) charset related issue in test coverage check

Open fuglede opened this issue 9 years ago • 3 comments

This Travis build, called from https://github.com/EFForg/https-everywhere/pull/3726, triggers an error which shouldn't really be triggered.

fuglede avatar Jan 01 '16 16:01 fuglede

It seems that the code is matching Unicode regex against IDNA-encoded domain/URL. Unfortunately, that can't be done (cleanly at least), because urlparse/urlunparse does not work with regexps. In the same manner, IDNA-encoding a regexp does not have the result you want, e.g.:

"^http://bernina-zürich\.ch/".decode("utf8").encode("idna") gives xn--^http://bernina-zrich\\-8lc.ch/

I didn't write the code for the test coverage and if you don't need them, just disable them by setting check_coverage to false (it's false by default).

I'll change the sample config for the coverage tests to be turned off (as it should be).

hiviah avatar Jan 04 '16 14:01 hiviah

I still run in this issue. Is there any chance to get a fix for this or something I where I could help?

J0WI avatar Mar 09 '16 21:03 J0WI

Sorry, but what this project would need most is a new maintainer. Since I started a new job I probably won't find time for this, it seems.

hiviah avatar Mar 22 '16 22:03 hiviah