hivemq-mqtt-client icon indicating copy to clipboard operation
hivemq-mqtt-client copied to clipboard

Added the field localCorrelationData to MqttPublish for better flow-handling in reactive-APIs

Open codepitbull opened this issue 3 years ago • 7 comments

Motivation Using the reactive integrations (rxjava2/reactor) results in a situation where after an MqttPublish has been processed a Mqtt5PublishResult is forward in the stream. This object doesn't contain any processing context which makes a few usecases rather unintuitive to implement. In my case I am receiving from Kafka and want to commit AFTER the message has been sent to HiveMQ. For that I need to get the commit-offset to the end of the stream.

Changes To support the above mentioned usecase I added a localCorrelationData (similar to what Kafka is doing in their client-lib). This field is never propagated to HiveMQ but can be used down the streams. In my case I store the Kafka-Commit-Offset in there and use it to trigger the actual commit.

codepitbull avatar Oct 11 '22 07:10 codepitbull

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @codepitbull on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar Oct 11 '22 07:10 cla-bot[bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @codepitbull on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar Feb 15 '23 13:02 cla-bot[bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @codepitbull on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar Feb 15 '23 15:02 cla-bot[bot]

@cla-bot u so lazy

pglombardo avatar Feb 15 '23 15:02 pglombardo

@cla-bot check

pglombardo avatar Feb 15 '23 15:02 pglombardo

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 15 '23 15:02 cla-bot[bot]

Hi all - let's wrap up this PR this week if possible so it doesn't go stale.

pglombardo avatar Mar 20 '23 09:03 pglombardo