hivemq-mqtt-client
hivemq-mqtt-client copied to clipboard
hivemq
Added custom http headers to MqttWebSocket
Motivation Added the option to add custom http headers (eg bearer token authentication to reverse proxy) for websocket connection
Changes MqttWebSocketConfig
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hctemmel Thank you for your contribution. It seems to be pretty good, but before we can review and incorporate it, you need to sign our CLA. Please follow the instruction of the cla-bot's comment. If something is unclear please just ask.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
Hello @SgtSilvio. Do you need anything else from my side to start the review process? Thanks a lot and best regards.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hctemmel, @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
Sorry, please ignore the above messages from the cla-bot, I need to check who has access to [email protected]
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @skrutzler on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!
Hi @skrutzler, thank you for your contribution! Unfortunately the GitHub username (skrutzler) is not part of the list. Can you please send us an updated signed CLA with this username on the list as well? Thank you!
Hello. My username (preto) was on the signed CLA. skrutzler is just the changed nickname and belongs to the same registered user ( click on my profile to see it ;) @skrutzler ) I guess it would take me another 3 months with my employee legal department to get an updated document ...
@skrutzler I am very sorry for the delay. The easiest way would be to remove your commit, as it is an empty merge commit anyhow. Rebasing your branch on master should remove this commit. I can also help to do that once I find the time for it. Unfortunately we can not add preto to the CLA list, as this is actually your nickname and skrutzler is your username/profile on GitHub.
@SgtSilvio I think all requirements are met now and it can be merged if there are not any remarks.
Do you know by any chance when a new release with those changes might be triggered?
Hi @skrutzler - thanks for staying on top of this and traversing the cla bot. Either I or @SgtSilvio will take a look at this very soon and post an update.
Thanks for your work and patience on this @skrutzler! PR is merged. We'll put out a new release soon.