hivemq-edge icon indicating copy to clipboard operation
hivemq-edge copied to clipboard

fix(23934): Remove the "seletable" filter from the auto-complete selector

Open vanch3d opened this issue 7 months ago • 0 comments

See https://hivemq.kanbanize.com/ctrl_board/57/cards/23934/details/

This is a quick fix to the previous PR, which allows EVERY node discovered on the adapter to be selectable in the UI

Design

  • We have a significant ambiguity as to what makes a discovered node selectable in general
  • Specifically, in OPC-UA the existing rule based on VALUE or OBJECT doesn't seem to be working
  • The example given by one of our customers shows expected nodes that are OBJECT but not selectable
  • We cannot make an informed decision of this treatment, based on our fake data. We need real-life expertise with real-life OPCA-UA devices deeding Edge
  • The fix makes EVERY node selectable
    • users are not facing an empty list if their usable nodes are "unselectable"
    • if a wrong node is selected, the adapter will certainly fail and a relevant error message generated in the event log
    • the onus will be on the users to fix their mistake

Before

screenshot-localhost_3000-2024 07 10-12_01_52

For reference, this is the OPC-UA dummy : Screenshot 2024-07-10 at 12 02 25

After

screenshot-localhost_3000-2024 07 10-12_03_46

Note that it will affect EVERY adapter, including MODBUS, where the folder node will be displayed

screenshot-localhost_3000-2024 07 10-12_04_46

vanch3d avatar Jul 10 '24 09:07 vanch3d