hivemq-edge icon indicating copy to clipboard operation
hivemq-edge copied to clipboard

Refactor monorepo gradle files in order to have a single dependencies version

Open pjgg opened this issue 1 year ago • 5 comments

Motivation

In order to avoid issues with transitive dependencies and reduce the number of vulnerabilities (CVEs), it's convenient to have a single version for third-party dependencies, all managed from a central point (Gradle catalog)

This PR is refactoring the current Gradle files to reuse the same dependency declarations and also creates common dependency bundles.

Note: the Gradle refactor was started in the Athens hackathon but I could not finish on time, It took me ..."one" extra day (I finished today (one day later), in the airport).

IntelliJ will require gradle 8 or gradle 7 with this plugin: https://plugins.jetbrains.com/plugin/18949-gradle-libs-error-suppressor

My recommendation it´s to move on to Gradle 8 . No problem at all on Github Action or the terminal, is just a Intelij issue

pjgg avatar Oct 20 '23 17:10 pjgg

@cla-bot check

schaebo avatar Nov 09 '23 10:11 schaebo

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @pjgg on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar Nov 09 '23 10:11 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Nov 09 '23 10:11 cla-bot[bot]

@cla-bot check

schaebo avatar Nov 09 '23 10:11 schaebo

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Nov 09 '23 10:11 cla-bot[bot]