hius07

Results 177 comments of hius07

When building the list of the **default** default values the program iterates over all key-values from defaults.lua. https://github.com/koreader/koreader/blob/c345de5d711134d40f9b5ccb0942d7a3b7b8e4a2/frontend/apps/filemanager/filemanagersetdefaults.lua#L37-L45 But defaults.lua contains https://github.com/koreader/koreader/blob/c345de5d711134d40f9b5ccb0942d7a3b7b8e4a2/defaults.lua#L196 Lua `pairs` skips keys with `nil` values, so...

Coverting higlights to annotations. I'm lookin into it.

The bug in converting old **page bookmarks** in **pdf** files. Is being fixed today.

Please replace koreader/frontend/apps/reader/modules/readerannotation.lua with the attached file (remove txt extension). [readerannotation.lua.txt](https://github.com/koreader/koreader/files/15221189/readerannotation.lua.txt)

Does it happen on any file? Please describe the steps to reproduce the issue.

Sorry, cannot reproduce with my pdf files. Can you make one problematic note and show me the metadata file (only, no book).

PDF page bookmarks conversion fixed in https://github.com/koreader/koreader/pull/11761.

> Do you still want me to upload the metadata file? Yes please.

Thank you. The attached module should fix. [readerbookmark.lua.txt](https://github.com/koreader/koreader/files/15248010/readerbookmark.lua.txt) (The issue occurs for reverse sorting order only)

As usual, did you remove `txt` extension and put it to koreader/frontend/apps/reader/modules, then restart?