hius07

Results 177 comments of hius07

I do not like "complication". Neutral "items" works for me. EDIT: or "indicators", to be used in phrases like "battery indicator".

Is "divider" to name horizontal lines approved? If yes I'd change for bookmark list https://github.com/koreader/koreader/blob/c345de5d711134d40f9b5ccb0942d7a3b7b8e4a2/frontend/apps/reader/modules/readerbookmark.lua#L160

> it should probably be all separator or all divider In this PR "divider" is a horizontal line dividing the status bar, "separator" is a vertical line separating status bar...

As a workaround, this userpatch allows to reduce the highlight box height: https://github.com/koreader/koreader/issues/11581#issuecomment-2053705849

"No" to all of your assumptions. We cache one thumbnail for a book - not for History, or FM, or landscape, or portrait - just for a book. If the...

> So this delay in showing them is due to rescaling only? No, it's quick. For example, you open a folder with new books in FM Mosaic mode 2x2. You...

> if I switch to Landscape, should I see delay? Depends on the thumbnail size (that depends on the screen and grid dimensions) in Landscape and Portrait modes. If it...

Again, we do not trace **why** the thumbnail size changes (grid changes, mode changes, FM-Hist-Coll switch). We compare the cached size and the required size, that's it.

cbz are rendered by muPDF, double-page layout request is https://github.com/koreader/koreader/issues/10204. epub are rendered by crengine. Switching and shifting pages are doable I think.