mind-ar-js icon indicating copy to clipboard operation
mind-ar-js copied to clipboard

Published 20 hours ago • verified publisher icon hiukim

Fixes #325: Improve support for bundling/importing through vite.

Open roelvanhintum opened this issue 2 years ago • 3 comments

  • Updated dependencies
  • Remove exposing to window
  • Externalize all dependencies

roelvanhintum avatar Dec 30 '22 10:12 roelvanhintum

Is it going to break applications that install the library with

hiukim avatar Dec 31 '22 12:12 hiukim

@hiukim could be. I did not test using the script tag. I see i messed up with a last commit, which is just there for testing and shouldn’t be in the pull-request.

roelvanhintum avatar Dec 31 '22 14:12 roelvanhintum

@roelvanhintum I've noticed you externalized all the dependencies, but you didn't move them to peerDependencies block inside of package.json? Why not? Also, have you tested the examples to make sure they still work?

jmschrack avatar Jan 26 '23 03:01 jmschrack