mind-ar-js icon indicating copy to clipboard operation
mind-ar-js copied to clipboard

fix: too much zoom on multi camera devices for tracking

Open mateusmb opened this issue 2 years ago • 2 comments

This PR solves issue #105, where multi camera devices has the default camera selected, which in case is too zoomed in. This doesn't break the camera usage for devices which doesn't have this issue.

mateusmb avatar Jun 17 '22 20:06 mateusmb

@mateusmb Thanks for the PR. Can you help me understand what are you trying to fix?

I saw you are trying to select a camera with this label whenever possible: "camera2 0, facing back". What's the reason for doing that? Why "camera2 0, facing back" is the best camera?

hiukim avatar Jul 31 '22 18:07 hiukim

@hiukim It's a bit of a hacky solution, there is no real answer for "why" as I understand. This is just try and error on Samsung and other multiple lenses phones.

See this issue for more details, as AR,js seems to have the same problem.

Sov3rain avatar Aug 01 '22 09:08 Sov3rain

Hie @hiukim @Sov3rain @mateusmb

JxstWieslaw avatar Jan 18 '23 11:01 JxstWieslaw

Please refer to this update on how to pick camera: https://github.com/hiukim/mind-ar-js/issues/105#issuecomment-1575478582

Closing this PR. thx all.

hiukim avatar Jun 04 '23 09:06 hiukim