oci-api-php-request-sign icon indicating copy to clipboard operation
oci-api-php-request-sign copied to clipboard

standardize "method" casing

Open browner12 opened this issue 1 year ago • 1 comments

in_array() is case-sensitive, so if a non-fully uppercase version of "POST", "PUT", or "PATCH" is passed in, it will fail when very likely the intended outcome is that it passes.

function shouldHashBody(string $method): bool
{
    return in_array($method, ['POST', 'PUT', 'PATCH']);
}
    
var_dump(shouldHashBody('post')); //false
var_dump(shouldHashBody('POST')); //true

browner12 avatar Sep 04 '24 17:09 browner12

any updates?

browner12 avatar Dec 03 '24 16:12 browner12

one more bump

browner12 avatar Oct 27 '25 17:10 browner12