apihub
apihub copied to clipboard
hiteshchoudhary
Feat/expense split app
Hey @jwala-anirudh @wajeshubham This is draft PR for review of models routes and aggregation pipelines and helper functions This is mostly a work in progress most of the controllers are not tested yet as reviewed by anirudh in his comment #127 I am uploading it for initial review I will be using socket io for emitting expense group events after testing of all the routes thoroughly as socket io and configs are already present in the project I will integrating it at the very end
@arnb-smnta kindly go through the naming convention we are following for FreeAPI we are not following camel casing in file names and routes. Also, let us know once the PR is ready for review. Thank you!
Why is yarn.lock deleted? Please revert it back to its original state
@arnb-smnta kindly go through the naming convention we are following for FreeAPI we are not following camel casing in file names and routes. Also, let us know once the PR is ready for review. Thank you!
Please address this
@jwala-anirudh please see my new pr and see if it isok
I've checked and still cannot see the recovery of yarn.lock file here
@wajeshubham I have addressed the naming problem i think and also the yarn.lock problem i figure it out I think @jwala-anirudh its added can u just let me know if both the problems are addressed properly ?
@jwala-anirudh its added can u just let me know if both the problems are addressed properly ?
Why are you regenerating the yarn.lock file again? Just revert it back to it original format of what is present on master branch, the one which you have added comes with multiple security issues - it will reduce the reliability & we need to redo entire work. Cannot merge those changes
@jwala-anirudh i think it is done now can u confirm the yarn.lock file problem
@jwala-anirudh this is the new postman api collection corected the changes suggested by shubham
@wajeshubham commited the changes suggested by you just not deleted the route comments for my understanding ,I was thinking of deleting the route comments just before the final commit after all testing and approval has been done for merging will it be okay if I just leave the comments for now will surely delete before the final review
![pullpo-for-slack[bot] avatar](https://avatars.githubusercontent.com/in/246354?v=4 "Published by a pub.dev verified publisher"){kind=small}
@arnb-smnta Please go through all the review comments and fix those. If you have any doubts regarding any comment, please reply to the comment. Thank you.
@wajeshubham @jwala-anirudh I have resolved all the issues as stated and the API is working fine can you just go through the code if any modification is required or not