htop icon indicating copy to clipboard operation
htop copied to clipboard

Add Solarized color scheme

Open ngg opened this issue 8 years ago • 3 comments

This PR adds a new color scheme that looks good in Solarized terminals. It is a slight modification of the Black Night scheme. Based on https://bitbucket.org/ajenkins/htop-solarized/src/

ngg avatar Mar 09 '16 15:03 ngg

This seems to be a sensible addition. The current "Broken Gray" theme seems to be a compromise, since it doesn't make full use of the Solarized palette.

Solarized is an excellent colour scheme, but due to xterm limitations it requires applications to use a specifically designed theme. Since Solarized is so widely used, it seems to make sense to include such a theme in htop (since user-defined themes aren't supported).

willvousden avatar Apr 13 '16 12:04 willvousden

The end result looks like this on macOS' Terminal.app with a Solarized Dark color scheme: (bold text is displayed with bright colors, just like the GNOME Terminal)

htop_solarized_pr443

I find the usage of cyan excessive, but at least all the text is readable.


In comparison, this is how the scheme renders with the following changes, in the same conditions as above:

--- a/CRT.c
+++ b/CRT.c

   [COLORSCHEME_SOLARIZED] = {
-      [RESET_COLOR] = ColorPair(Cyan,Black),
+      [RESET_COLOR] = ColorPair(White,Black),
-      [DEFAULT_COLOR] = ColorPair(Cyan,Black),
+      [DEFAULT_COLOR] = ColorPair(White,Black),

htop_solarized_pr443_white_text


Since Solarized is so widely used, it seems to make sense to include such a theme in htop (since user-defined themes aren't supported). -- @willvousden

I also believe this comment is relevant, the future Convergent Terminal from Ubuntu will adopt Solarized as its default color scheme. @hishamhm wether this is a wise decision or not, it seems important that widely used tools like htop offer a certain level of compatibility with solarized.

edit: I just noticed the "Broken Gray" color scheme which looks good in Solarized terminals as well actually.

antoineco avatar Nov 28 '16 12:11 antoineco

Can we expect this PR to be merged?

willvousden avatar Feb 21 '18 15:02 willvousden