Hisham Bin Ateya

icon indicating a website link http://www.hishambinateya.com icon indicating an email [email protected]

icon location Yemen, Hadhramout, Mukalla icon location Microsoft MVP, works mostly in ASP.NET Core, Orchard Core, and Orchard Core Contrib. Also, I made massive contributions in localization area in many OSS

Results 1450 comments of Hisham Bin Ateya

DictionaryValue should return the item count for ToNumberValue()

> DictionaryValue.ToNumberValue() always returns 0. It's right, because `Dictionary` can't be converted to number, similarlly you will find `ToStringValue()` returns empty string

DictionaryValue should return the item count for ToNumberValue()

I disagree for `ArrayValue` too, @sebastienros I'm not sure why we should have array length

DictionaryValue should return the item count for ToNumberValue()

For `ArrayValue` we could use the first element value, in case if the `FluidValue` is numeric

DictionaryValue should return the item count for ToNumberValue()

IMHO `ToNumber()`, `ToString()` should trying to convert the current value to their equivalent, no need to assume something that are not expected for the audience

Add translate filter and supporting infrastructure.

Interested, I need to have a look to this one ASAP

Add translate filter and supporting infrastructure.

At the first glance I'm not sure if @sebastienros agree to use RESX for localization string

Add translate filter and supporting infrastructure.

IMHO this filter might go into OC

Implement Media Filters

@deanebarker please refer to https://shopify.dev/api/liquid/filters/media-filters#img_tag and https://shopify.dev/api/liquid/filters/media-filters#video_tag

Implement Media Filters

While Fluid based on Liquid, such filters will be a plus, moreover they will be helpful for Orchard Core

Implement Media Filters

> If you want to use this in Orchard (which makes sense because Orchard has knowledge of the URL pathing) , then I feel like this is a ticket for...