stacks.js icon indicating copy to clipboard operation
stacks.js copied to clipboard

feat!: Update post-condition representation to humand readable types

Open janniks opened this issue 1 year ago • 2 comments

  • update post-condition representations for SIP

Example Post-conditions should now be human-readable and serializable. This is a breaking change.

const condition = {
  type: 'stx-postcondition',
  address: 'SP...123',
  condition: 'eq',
  amount: 10000
}

janniks avatar Jul 08 '24 15:07 janniks

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs 🛑 Canceled (Inspect) Sep 17, 2024 3:18pm

vercel[bot] avatar Jul 08 '24 15:07 vercel[bot]

👏 👏

Great changes!

I have a doubt regarding the sent not-sent keywords.

Does the past tense make more sense than the previous version (Sends, DoesNotSend)?

Yeah, they're not perfect. I also prefer "will" "does" (from the perspective of the person constructing the PC before the tx, but folks on the wallets standards calls prefer red "post"-tense for "post" conditions 😅

janniks avatar Jul 11 '24 08:07 janniks