stacks-blockchain-api icon indicating copy to clipboard operation
stacks-blockchain-api copied to clipboard

Handle re-orgs for the ft/nft metadata tables

Open asimm241 opened this issue 3 years ago • 6 comments

Describe the bug There are forking scenarios that aren't handled by the queries against the ft_metadata and nft_metadata tables.

See details here : https://github.com/blockstack/stacks-blockchain-api/pull/576#discussion_r664776323

asimm241 avatar Jul 07 '21 11:07 asimm241

@zone117x do we need to add microblock_hash, microblock_sequence, microblock_canonical to these tables as well in addition to canonical. ?

asimm241 avatar Jul 20 '21 12:07 asimm241

Correct

zone117x avatar Jul 20 '21 19:07 zone117x

A lot of rich dialog and commentary at https://github.com/hirosystems/stacks-blockchain-api/pull/576, which attempts to address the said bug(s). Not entirely clear whether we are kosher with the improvements or what is pending.

Perhaps @asimm241, if you could clarify what remains, it would help very much. 🙏🏽

sabbyanandan avatar Mar 04 '22 20:03 sabbyanandan

@sabbyanandan I'm not sure but I think this should be closed now. We decided to work on it after the #743 but then It was decided that we are not going to implement #743. So this issue should be closed now.

asimm241 avatar Mar 05 '22 05:03 asimm241

Thanks for checking and the follow-up, @asimm241.

sabbyanandan avatar Mar 07 '22 16:03 sabbyanandan

#743 is unrelated to this task which I believe is still outstanding

zone117x avatar Mar 12 '22 07:03 zone117x

Deprecated by #1222

rafaelcr avatar Sep 20 '22 18:09 rafaelcr