explorer icon indicating copy to clipboard operation
explorer copied to clipboard

Remove warning in extension when deploying a contract

Open friedger opened this issue 2 years ago • 4 comments

Describe the bug A warning about insecure transaction is shown in the extension pop-up when I try to deploy a contract in the sandbox.

To Reproduce Go to sandbox and deploy a contract using Hiro wallet 2.15.2

Expected behavior Use deny mode and do not show the warning.

friedger avatar Aug 29 '21 20:08 friedger

@jasperjansz I presume the integration change here is simply not to display a warning for contract deploys in particular?

markmhendrickson avatar Aug 30 '21 10:08 markmhendrickson

hey @friedger it's my understanding a contract deploy can call functions of other contracts and make transfers. Is that the case?

jasperjansz avatar Aug 30 '21 11:08 jasperjansz

Correct

friedger avatar Aug 30 '21 11:08 friedger

In that case, I suppose we just need to modify the Explorer integration to use "deny" mode.

markmhendrickson avatar Aug 30 '21 12:08 markmhendrickson