connect icon indicating copy to clipboard operation
connect copied to clipboard

Add persisted version of `showConnect`

Open janniks opened this issue 1 year ago • 4 comments

Right now showConnect doesn't persist selection (for backwards comp)

But users might want this, so we should have a showConnectPersist, which stores the provider id.

This could be changed to a breaking change to always persist showConnect later.

janniks avatar Feb 26 '24 15:02 janniks

This would be a great addition, especially as we move away from shared namespaces.

kyranjamie avatar Feb 27 '24 07:02 kyranjamie

Might it even be better to have showConnect be the persisted version, since presumably this is what developers expect / the need for not persisting is less common?

markmhendrickson avatar Feb 27 '24 09:02 markmhendrickson

This is important as once apps have authenticated, another wallet provide may be called erroneously, owing to how they complete for the shared namespace.

kyranjamie avatar Feb 29 '24 11:02 kyranjamie

+1 sort of agree here But will be breaking, as to get the old behavior, folks would need to call disconnect each time. (Which they may not know about). But seems like a good change 👍🏻

janniks avatar Feb 29 '24 11:02 janniks