connect icon indicating copy to clipboard operation
connect copied to clipboard

Show other wallet options

Open yknl opened this issue 2 years ago • 6 comments

Currently Connect UI only points users to download Hiro wallet if no wallet installation is detected.

The UI should be changed to let users know of other wallet options like Xverse for mobile. Especially since Hiro wallet is not on mobile and mobile makes up more than half of all web traffic. This causes users to drop off when they visit apps.

image

image

yknl avatar Aug 11 '22 08:08 yknl

I agree about these needs, though I'd suggest keeping the thread going on https://github.com/hirosystems/connect/issues/101 about them since we've already had some early explorations there that could be helpful for pushing this forward.

markmhendrickson avatar Aug 11 '22 09:08 markmhendrickson

Maybe we should co-author a SIP with a proposal for provider mgmt? @yknl

kyranjamie avatar Aug 11 '22 16:08 kyranjamie

I agree about these needs, though I'd suggest keeping the thread going on #101 about them since we've already had some early explorations there that could be helpful for pushing this forward.

That thread has been open for over a year. I think we should move ahead with at least a temporary solution instead of waiting for the perfect one. We'll open a pull request.

Maybe we should co-author a SIP with a proposal for provider mgmt? @yknl

@kyranjamie what do you have in mind for the proposal?

yknl avatar Aug 15 '22 15:08 yknl

@yknl Perhaps this belongs in a more general SIP, but something that describes how an extension provider object is injected into a page, in a way which doesn't create naming conflicts/overwriting the same window.StacksProvider object.

(this happens rn with Metamask and Coinbase wallet)

kyranjamie avatar Aug 16 '22 08:08 kyranjamie

@yknl I presume this WalletConnect grant request is related? https://github.com/stacksgov/Stacks-Grant-Launchpad/issues/646

markmhendrickson avatar Aug 16 '22 09:08 markmhendrickson

@yknl Perhaps this belongs in a more general SIP, but something that describes how an extension provider object is injected into a page, in a way which doesn't create naming conflicts/overwriting the same window.StacksProvider object.

(this happens rn with Metamask and Coinbase wallet)

Let's start one.

@yknl I presume this WalletConnect grant request is related? stacksgov/Stacks-Grant-Launchpad#646

No, but it is related. How does stacks.js plan to be inter-operable with WalletConnect? Right now devs will have to choose one or the other.

yknl avatar Aug 24 '22 08:08 yknl

https://github.com/hirosystems/connect/pull/272

janniks avatar Sep 28 '22 13:09 janniks