clarinet icon indicating copy to clipboard operation
clarinet copied to clipboard

Status indicators not working in `clarinet integrate`, always grey

Open jbencin opened this issue 2 years ago • 7 comments

In the TUI interface for clarinet integrate, all of the status indicators are grey, instead of the red/yellow/green that they are supposed to be. Other colors display fine, like those for the logs and block height. Here's a screenshot:

no-colors

I suspect I'm seeing this problem because I'm using a different environment than most people (Linux with KDE). Full details of my setup:

  • Clarinet commit: 354088801115db74c81f8a70faa562c2a279f615
  • Shell: bash 5.1.16
  • Terminal: Konsole 22.12.0
  • Desktop Environment: KDE Plasma 5.26.5
  • OS: Manjaro Linux with kernel 5.15.85

jbencin avatar Feb 23 '23 14:02 jbencin

@jbencin Do you still experience this issue?

hugocaillard avatar Nov 06 '23 10:11 hugocaillard

Yes. This is what I see as of commit 5fa90e46:

image

jbencin avatar Nov 08 '23 15:11 jbencin

@jbencin It's trying to display the following emojis 🟥 🟨 🟩 Is it possible that your terminal or OS doesn't support those emojis?

hugocaillard avatar Nov 08 '23 15:11 hugocaillard

I see them fine in my browser (Brave). If I paste them into vim I see:

image

So it does display something different for each one, but it's just drawing it like regular text, not displaying an image. I get the same thing in both terminals I have installed (Konsole and Alacritty), and I'm just using the default settings for both, so I imagine this would affect a lot of developers.

I'm not sure we can rely on terminals to display emoji correctly. It works fine in OS X, which is what most people at Hiro use, but I'm not sure if this is well supported on Windows or Linux. See here for an alternative way to do colors in tui-rs (now ratatui)

jbencin avatar Nov 08 '23 15:11 jbencin

Ok thank you. We'll figure something out 👌

hugocaillard avatar Nov 08 '23 15:11 hugocaillard

I have this working now. In Konsole, if you open settings and go "Appearance" -> "Complex Text Layout" you can select an "Emoji font" (the only one available for me was "Noto Color Emoji"). Then it will use that font only to display emoji.

I think this issue should stay open however, because emoji support (particularly with colors/images) in the terminal is probably not something we can rely on

jbencin avatar Nov 08 '23 16:11 jbencin