clarinet icon indicating copy to clipboard operation
clarinet copied to clipboard
verified publisher icon hirosystems

CI job should still run if only Cargo.toml changes

Open obycode opened this issue 3 years ago • 4 comments

obycode avatar Feb 18 '22 22:02 obycode

Hello @obycode !

I would like to contribute with this issue. Could you please provide more info on that? When changes to Cargo.toml aren't triggering the CI? Is on a pull request creation? Or on a push to branches?

Thanks!

csgui avatar Jan 06 '23 19:01 csgui

Thanks @csgui. There have been some changes to the CI configuration since this issue was posted, so it may not be relevant anymore. Perhaps we should first start by opening a PR where only the Cargo.toml is changed and then check if the CI jobs run. When I created this issue, there had been a PR where they didn't run in that scenario, but I have a feeling it has since been fixed through unrelated changes.

obycode avatar Jan 06 '23 20:01 obycode

Perhaps we should first start by opening a PR where only the Cargo.toml is changed and then check if the CI jobs run.

Hi @obycode,

I was checking the Cargo.toml and notice that the clarity-repl component is missing from the members list.

We can add that to the list and check if the CI will run. What you think?

csgui avatar Jan 06 '23 21:01 csgui

Yes, that sounds good to me. @lgalabru - is that left out intentionally for any reason?

obycode avatar Jan 11 '23 17:01 obycode