hirosassa

Results 35 comments of hirosassa

@jessicasomaiya Thanks for your report! FYI, the following commit is the sample of implementation to solve this issue. I'm looking forward to your PR! https://github.com/hirosassa/sdk-codegen/commit/6ef4a4149ee4f4eff2dae52489156f7c714876c5

I think @jessicasomaiya's implementation. @jeremytchang What do you think?

Hi, could you review this changes?

@jeremytchang Hi, could you review this change?

@jkaster Hi, cloud you review this PR?

@jeremytchang Thank you for the review! I'll create a example to reproduce the error and add integration test if it is needed (maybe this weekend).

@jeremytchang Here's the minimum example of reproducing error (need to run this on the local PC). https://go.dev/play/p/EFRxP79d9z9 This example fails with `failed to delete: EOF` at line 77. I'll implement...

integration test added in [3a4cdcc](https://github.com/looker-open-source/sdk-codegen/pull/1074/commits/3a4cdcc287c5b044b575ae54aa689a99c37682a1)

@jeremytchang Could you approve to run github actions workflow for confirming the IT run correctly?

@jeremytchang Could you approve to run CI? https://github.com/looker-open-source/sdk-codegen/pull/1074#issuecomment-1218537111