prestissimo icon indicating copy to clipboard operation
prestissimo copied to clipboard

Readme: should highlight that improvement only without local composer cache

Open skonrad opened this issue 5 years ago • 6 comments

Note: The readme already states that the plugin speeds up the download of packages.

Though this fact should be pressed harder to ensure that ppl. who just fly over the description get the point that it only improves the download-speed (pre-fetches packages in parallel). Was about to create an actual "issue" where there is none.

If the cache is already available (all packages available in composer-cache) the plugin does not give any improvements. Though it would probably nice if it would actually override the installation-process and unpack the cached packages with multiple threads ;)

The advantage in my specific case is very limited as my cache is preserved and only purged on a monthly basis.

skonrad avatar May 10 '19 00:05 skonrad

What kind of sentences do you agree with?

hirak avatar May 10 '19 08:05 hirak

Something in the vicinity of

Note that this plugin improves speed of package downloads only. It does not influence the speed of the installation process if all packages are available inside the local composer-cache.

maybe?

That would be more then sufficient in my eyes.

skonrad avatar May 10 '19 17:05 skonrad

don't mean to derail here, but I'm just curious, if this package is as useful as I feel it is (been using it for 2 years+ now and see no reason to stop), why hasn't Composer implemented this functionality as part of the core Composer installer? o_O

vesper8 avatar May 24 '19 10:05 vesper8

@vesper8 it is already merged to Composer's 2.0 branch.

kubawerlos avatar May 25 '19 06:05 kubawerlos

Is it true that there's no benefit when packages are cached? The animated gif on the homepage (of the Laravel install) shows packages being loaded from cache, which seems somewhat deceptive if true. It also looks like the Composer plugin does other stuff (such as with dependency sorting) that might have performance implications even with cached packages.

danepowell avatar Feb 11 '20 02:02 danepowell

Ah... I just noticed that when Prestissimo is installed, Composer always claims packages are "loading from cache" even on a cold cache. That seems like its own point of confusion, but at least explains the discrepancy in the readme.

danepowell avatar Feb 11 '20 02:02 danepowell