laravel-multi-tenant icon indicating copy to clipboard operation
laravel-multi-tenant copied to clipboard

4.2 Compatibility?

Open inctor opened this issue 9 years ago • 7 comments

In the composer file, it's requiring Laravel 5.2 and Illuminate/Support 5.2?

Should this not be lowered to account for 4.2 support?

Currently i can't update composer which is locked to this commit "aura-is-here/laravel-multi-tenant": "dev-master#9140a72432d1ac8d1f3d4e09d0a390a98b2bc879"

To prevent earlier compatibility issues, i had to lock it.

Can you update the composer files in this repo, to make sure it's Laravel 4.2 supported?

inctor avatar Jan 19 '16 12:01 inctor

Seconding this. Right now it's not viable to upgrade to Laravel 5 and this is preventing me from installing other packages.

joeserg avatar Jan 19 '16 15:01 joeserg

@inctor, looks like we are using the same commit! Having dug through the other issues I discovered there's a 4.2 branch you can use. I modified the line in my composer.json to the following:

"aura-is-here/laravel-multi-tenant": "dev-laravel-4.2#9140a72",

Now when I run composer update all is well.

joeserg avatar Jan 19 '16 16:01 joeserg

Hey guys, sorry that was a mistake. I have updated this package for Laravel 5.2+ and moved it to https://github.com/HipsterJazzbo/Landlord, but I left this package here for legacy support and forgot to change the composer file. Should be fine now for 4.2 — 5.1.

hipsterjazzbo avatar Jan 19 '16 19:01 hipsterjazzbo

Ugh I forgot there's some other stuff. I won't have time to fix this today sorry guys, but if someone makes a PR for 4.2 compatibility I'll accept it soon as I can.

hipsterjazzbo avatar Jan 19 '16 19:01 hipsterjazzbo

@joeserg Yeah, i don't know why/what it is, with the later commits, but it produces some strange errors where i can't really find the explicit cause of. But that specific commit works as expected for our project. Might try and go for latest commit and find out what changed.

For now i'm using the dev-laravel-4.2 and it works fine, and i can continue the dev.

inctor avatar Jan 20 '16 09:01 inctor

Someone let me know if it works now on 4.2 with #78 merged, and I'll tag a version

hipsterjazzbo avatar Jan 20 '16 20:01 hipsterjazzbo

I did an update today and got this error:

  • Installing aura-is-here/laravel-multi-tenant (dev-master f4b4cc0)
PHP Fatal error:  Call to undefined method AuraIsHere\LaravelMultiTenant\LaravelMultiTenantServiceProvider::publishes() in /home/vagrant/www/clients/nazar/vendor/aura-is-here/laravel-multi-tenant/src/LaravelMultiTenantServiceProvider.php on line 19
PHP Stack trace:
PHP   1. {main}() /home/vagrant/www/clients/nazar/artisan:0
PHP   2. Illuminate\Console\Application::start() /home/vagrant/www/clients/nazar/artisan:46
PHP   3. Illuminate\Console\Application::make() /home/vagrant/www/clients/nazar/vendor/laravel/framework/src/Illuminate/Console/Application.php:33
PHP   4. Illuminate\Foundation\Application->boot() /home/vagrant/www/clients/nazar/vendor/laravel/framework/src/Illuminate/Console/Application.php:44
PHP   5. array_walk() /home/vagrant/www/clients/nazar/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:585
PHP   6. Illuminate\Foundation\Application->Illuminate\Foundation\{closure}() /home/vagrant/www/clients/nazar/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:585
PHP   7. AuraIsHere\LaravelMultiTenant\LaravelMultiTenantServiceProvider->boot() /home/vagrant/www/clients/nazar/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:585
{"error":{"type":"Symfony\\Component\\Debug\\Exception\\FatalErrorException","message":"Call to undefined method AuraIsHere\\LaravelMultiTenant\\LaravelMultiTenantServiceProvider::publishes()","file":"\/home\/vagrant\/www\/clients\/nazar\/vendor\/aura-is-here\/laravel-multi-tenant\/src\/LaravelMultiTenantServiceProvider.php","line":19}}

divdax avatar Jan 28 '16 15:01 divdax