php-fpm_exporter icon indicating copy to clipboard operation
php-fpm_exporter copied to clipboard

support config-file

Open lazychanger opened this issue 4 years ago • 4 comments
trafficstars

#93

lazychanger avatar May 28 '21 07:05 lazychanger

@estahn i fixed issue #93 , please help me review the code

lazychanger avatar May 29 '21 02:05 lazychanger

Please check if ENV is prior to values in configuration file. If not it can break the way that debian package Prometheus export (using /etc/default/<name_exporter>.conf file for parameters) that currently use ENV prior to configuration to redefine value. Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

itcsoft54 avatar Sep 08 '21 15:09 itcsoft54

Please check if ENV is prior to values in configuration file. If not it can break the way that debian package Prometheus export (using /etc/default/<name_exporter>.conf file for parameters) that currently use ENV prior to configuration to redefine value. Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

I think ENV has a higher weight than files. so you can see use mapEnvVars to override the file configuration. My english for Google Transfer. Please don't mind. Thanks for you review.

lazychanger avatar Sep 09 '21 01:09 lazychanger

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 23:01 stale[bot]