Mark Hiner

Results 89 comments of Mark Hiner

I created [a tag](https://github.com/imagej/imagej-launcher/releases/tag/imagej-launcher-native-split) for the the last commit with native code. Note also that the appveyor webhook was turned off.

Note that for `napari-imagej`, the current latest release of `0.1.0` doesn't seem to work well when wrapping local installs so testing should be done using `main` at the moment

Fiji is in the process of updating to a new launcher that will support newer Java versions and hopefully make future maintenance easier. In this case I expect the code...

>([ImageTitleToImagePlusConverter](https://github.com/imagej/imagej-legacy/blob/7eac77ab28901975fc6bf0566a899cf1bef06d97/src/main/java/net/imagej/legacy/convert/ImageTitleToImagePlusConverter.java) is a likely suspect) OK obviously it wasn't the title converter but [DatasetToImagePlusConverter](https://github.com/imagej/imagej-legacy/blob/7eac77ab28901975fc6bf0566a899cf1bef06d97/src/main/java/net/imagej/legacy/convert/DatasetToImagePlusConverter.java#L69) which registers `Datasets` blindly without checking for existing mappings. A simple fix. We also decided to...

In conjunction with [these imagej-legacy changes](https://github.com/imagej/imagej-legacy/tree/img-plus-support) this branch now appears to resolve the [Fiji input harvester bug](https://github.com/fiji/fiji/issues/349). **However**, the `String` de-duplication is of course fragile, and does not address one...

OK, decided that this is the least intrusive change (compared to converting) and we can fix the `ImagePlus` title elsewhere if needed

I'm not sure how to debug this further. I tried modifying this bit to run on the EDT: ``` - locked (a java.awt.EventQueue$1AWTInvocationLock) at java.awt.Window.doDispose(Window.java:1210) at java.awt.Window.dispose(Window.java:1147) at ij.ImageJ.run(ImageJ.java:867) at...

Coming back to this because of https://github.com/fiji/fiji/issues/375 I currently have [a branch](https://github.com/imagej/imagej-legacy/tree/windows-deadlock) where I'm trying to solve this. It's unclear if [this `IJ1Helper.dispose` logic](https://github.com/imagej/imagej-legacy/blob/c24d491123dc3d3e1ee484e7b3a1833ada83ec7a/src/main/java/net/imagej/legacy/IJ1Helper.java#L245-L255) ever worked on windows, since it...

FWIW, removing the [shutdown hook](https://github.com/scijava/scijava-common/blob/1b25c5802e42d1061645b3597c18242cfda3b879/src/main/java/org/scijava/Context.java#L316) allows `ctrl + c` to work on Windows and doesn't seem to interfere with the Jaunch Fiji upgrade process nor `napari-imagej`, so simply disabling the...

>For the moment, try downloading a fresh Zulu OpenJDK 21 and replacing the one in Fiji-Future.app/java @ctrueden no luck. Double-clicking still doesn't work