react-native-numeric-input icon indicating copy to clipboard operation
react-native-numeric-input copied to clipboard
verified publisher icon himelbrand

Use TextStyle for iconStyle

Open peterkuiper opened this issue 5 years ago • 2 comments

Fixes #53

peterkuiper avatar Feb 05 '20 17:02 peterkuiper

Thanks a lot for your contribution! Please make it possible to use one or the other... depending on need

himelbrand avatar Jan 29 '22 15:01 himelbrand

@himelbrand I'm not sure why there should be an option of different types for iconStyle. If you look at IconProps from react-native-vector-icons/Icon, it extends TextProps from react-native, which in turn uses TextStyle for the style prop. It seems like this PR is correct and will eliminate Typescript errors for users, specifically when attempting to set the color of the icons. But maybe I am misunderstanding your comment.

jarod-legault avatar May 30 '24 20:05 jarod-legault