Martin Hradil

Results 60 comments of Martin Hradil

@jeff-phillips-18 Perhaps the `jsdom` dependency is simply too specific here? I mean, `1.0.0-pre.6` sounds like it should have a `^` or `~`... Upgrading to d3 4 can't quite happen for...

Ah, I have an almost-fix for this one https://github.com/ManageIQ/manageiq-ui-service/pull/1580 I'll try to get it ready :)

So.. these are the changes needed to achieve push updates: * first, we need the backend to know that an update has happened for any kind of change - since...

@ShaiahWren looks like this will need a rebase? :) And, LGTM too, although > `cy.contains(thisCollectionName).should('not.exist');` this will work both when the collection doesn't exist because it was removed, or when...

Might want to make this a draft before the API changes are merged and released?

I'm pretty sure we'll have to fix any type errors before merging instead of hiding them. Otherwise, looks good :+1: EDIT: we'll try to make the typescript rules a bit...

it should not be a problem in `HubNamespace` but in `HubItemsResponse` .. the API response you're getting back is not just the namespace, it's something like `{ data: the_namespace, meta:...

Not so sure about this one, can we just add Deprecate and Undeprecate as 2 separate actions, and hide the one that does not apply?

Looks like previously, we would only ever see a one-line help text ending in an ellipsis when too long, with a Tooltip when hovering. After, we see the full text,...

Looks like the missing help buttons are being addressed in https://github.com/ansible/ansible-ui/pull/2782 :). So I guess this one just needs green tests now :)