relic_bazaar icon indicating copy to clipboard operation
relic_bazaar copied to clipboard

null safety added to the project

Open VaishnaviSood opened this issue 3 years ago • 7 comments

Migrated the dependencies to null-safety (adobe_xd and razorpay_flutter are not compatible with null safety which caused problems). So now the project is not sound null safe. It is a type of mixed version. I thoroughly checked the code for non-nullable and nullable types and edited the code accordingly. If there is any issue regarding it, please inform.. Closes #64

VaishnaviSood avatar Mar 09 '21 12:03 VaishnaviSood

@VaishnaviSood Was there a requirement to update the environment SDK? And can you attach a gif of the checkout window on the cart screen, so that I can verify that Razorpay is still working along with the Adobe XD.

himanshusharma89 avatar Mar 09 '21 13:03 himanshusharma89

@VaishnaviSood Was there a requirement to update the environment SDK? And can you attach a gif of the checkout window on the cart screen, so that I can verify that Razorpay is still working along with the Adobe XD.

@VaishnaviSood do response whenever you can because I would like to merge this PR as soon as possible.

himanshusharma89 avatar Mar 09 '21 17:03 himanshusharma89

Firstly sorry for the late reply... and yes it was a requirement to update the SDK as the latest version of Dart supports null safety. Razorpay is working fine.....but I guess the only problem now is that app would not run...we have to run the app by command 'flutter run --no-sound-null-safety', because the app is not sound null safe. I hope the video would demonstrate working of razorpay.

https://user-images.githubusercontent.com/61686542/110519468-5b4cb100-8133-11eb-83a8-b2bb68e5e657.mp4

VaishnaviSood avatar Mar 09 '21 18:03 VaishnaviSood

Okay @VaishnaviSood thanks for the update, let the PR exists until we somewhat finalise this app. You can create the null safety issue in these plugins as I told you earlier. And you can proceed with other issues. I'll let you know when to update this PR.

himanshusharma89 avatar Mar 09 '21 18:03 himanshusharma89

@VaishnaviSood I am converting this PR to draft. I'll try to release the null safety version of Razorpay as soon as possible to make the project sound null safe.

himanshusharma89 avatar Mar 12 '21 14:03 himanshusharma89

ohkay!...That's good...but the adobe_xd package also did not have a null safe version. If you could do something about that. And do inform me when its all done..I'll make the required changes

VaishnaviSood avatar Mar 12 '21 14:03 VaishnaviSood

ohkay!...That's good...but the adobe_xd package also did not have a null safe version. If you could do something about that. And do inform me when its all done..I'll make the required changes

I think we can remove the adobe_xd, I'll check it and update you soon.

himanshusharma89 avatar Mar 12 '21 15:03 himanshusharma89