Joerg Henrichs

[PSyData] read/write access computation misses accesses in declaration

4

The UM physics contain for example: ``` real :: k_blend_tq(pdims%i_start:pdims%i_end,pdims%j_start:pdims%j_end), & ! IN Theta level for blending height. ``` The kernel extraction misses the accesses to `pdims`, therefore the arrays...

While the API specific types are replaced with the corresponding plain Fortran types in a driver (e.g. an LFRic field becomes a 1D array), any module included might be using...

Kernel extraction and partially written fields

8

The kernel ../calc_dep_pts_alg_mod_psy-invoke_10_calc_upwind_detj_at_w2_kernel_type\:calc_upwind_detj_at_w2_code\:r0 does: ``` real(kind=r_tran), dimension(undf_w2), intent(inout) :: detj_w2 do k = 1, nlayers-2 df = T detj_w2(map_w2(df)+k) = & ``` I.e. it only writes the top part of...

Once #2422 (support for generic interface) is on master, the fparser based collecing of module information in the ModuleManager (and/or ModuleInfo object) can be replaced with using the PSyIR.

#2471 added a script to update the (c) statements, and I have two additional scripts that should be added: - [ ] pycov: tests coverage for a file when given...

Add a script to PSYCLONE_ROOT/utils that will update all (c) statements to the current year

Using a user-defined type seems to be extracted correctly: ``` CALL extract_psy_data%PreDeclareVariable("tdims%i_end@atm_fields_bounds_mod", tdims%i_end) CALL extract_psy_data%PreDeclareVariable("tdims%i_start@atm_fields_bounds_mod", tdims%i_start) CALL extract_psy_data%PreDeclareVariable("tdims%j_end@atm_fields_bounds_mod", tdims%j_end) CALL extract_psy_data%PreDeclareVariable("tdims%j_start@atm_fields_bounds_mod", tdims%j_start) ... CALL extract_psy_data%ProvideVariable("tdims%i_end@atm_fields_bounds_mod", tdims%i_end) CALL extract_psy_data%ProvideVariable("tdims%i_start@atm_fields_bounds_mod", tdims%i_start) CALL...

UnknownFortranDataTypes

5

I have found a few code examples in LFRic where an UnknownFortranDataType is used: ``` real(kind=r_tran), allocatable, dimension(:) :: dep_pts_z_data_post ! UnknownFortranDataType INTEGER(KIND = i_def), PUBLIC, PROTECTED :: vertical_limit =...

":" in filenames are inconvenient, they stop tab-file-name completion (since the ":" must be escaped (at least on my WSL). It is also harder to use these names in Makefiles...

#443 Support flag that triggers fparser to read code in OpenMP conditional sentinels

3

Fixed #443, and is important for FAB to detect dependencies in omp sentinels. The implementation is (unfortunately) on two different levels: 1. Fixed format is handled on a line by...