Joerg Henrichs
Joerg Henrichs
I am a bit late to the party, and it appears that we are getting off the actual subject (symbol/symbol table equality - now we are talking about statement/subroutine equality)...
Sure, but I would think that's extremely low priority? Afaik our support for non-Fortran is pretty minimal. But otherwise I agree, specifying a default language in the config file would...
OK, it finally passed everything. Ready for a first look (very gentle please, I am shy :) )
> With compilation enabled, I get 13 test failures: > > ``` > FAILED dynamo0p3_quadrature_test.py::test_face_qr[True] - AssertionError: ass... > FAILED dynamo0p3_quadrature_test.py::test_face_qr[False] - AssertionError: as... > ... > FAILED domain/lfric/transformations/dynamo0p3_transformations_test.py::test_haloex_rc4_colouring[False] >...
### Item 1 We can't run dependency analysis before the psyir tree is lowered, since e.g. `DynLoop.start_expr` (and stop_expr) try to look up the variable name in the symbol table,...
My only concern would be that the examples need to become a lot more elaborate since we then would have to have fully working code, not just a few lines...
'combine' as in: have examples actually tested, and automatically included in our docs, i.e. we could guarantee that the examples in our documentation works (I believe some of the dependency...
We agreed not to go any further with this the way it is, to avoid unnecessary complex build environment. But in order to make it faster to run small compile...
I am assigning this to me for now to avoid anyone else working on it. While creating the PSyIR for a kernel call (for extract driver creation long term), I...
Note that the above solution is wrong and an obvious bad work around, since different precisions could be used, which will still cause an exception. Plus the existing code in...