hikari icon indicating copy to clipboard operation
hikari copied to clipboard

Published 20 hours ago • verified publisher icon hikari-py

Threads

Open FasterSpeeding opened this issue 2 years ago • 14 comments

Summary

Threads

Checklist

  • [ ] I have run nox and all the pipelines have passed.
  • [ ] I have made unittests according to the code I have added/modified/deleted.

Related issues

FasterSpeeding avatar Oct 04 '21 01:10 FasterSpeeding

A thread member cache store isn't feasible for the initial implementation as this'd require a decided upon strategy for pre-loading cache resources over REST otherwise the thread member stores for most threads will be incomplete.

More consideration probably has to be put into how archived threads are handled in the cache since the docs suggest these don't get synced like active threads.

Currently the thread cache is not reliable as it cannot account for losing access to seeing threads due to permission changes

FasterSpeeding avatar Oct 04 '21 01:10 FasterSpeeding

~~audit log entry types~~

FasterSpeeding avatar Oct 06 '21 04:10 FasterSpeeding

~~message endpoints need thread_id~~

FasterSpeeding avatar Oct 07 '21 23:10 FasterSpeeding

~~Replace the deprecated GET /channels/{channel.id}/threads/active endpoint with GET /guilds/{guild.id}/threads/active~~

FasterSpeeding avatar Oct 13 '21 23:10 FasterSpeeding

~~https://github.com/discord/discord-api-docs/pull/3998~~

FasterSpeeding avatar Oct 26 '21 17:10 FasterSpeeding

~~Check for HAS_THREAD message flag~~

FasterSpeeding avatar Mar 07 '22 08:03 FasterSpeeding

Apart from conflicts and open conversations, LGMT

Thanks a lot for investing the time and working on this @FasterSpeeding. Greatly appreciated

davfsa avatar Mar 27 '22 18:03 davfsa

A few return types have to be updated to PermissibleGuildChannel:

  • hikari.Guild.get_channel()
  • hikari.Guild.get_channels()
  • hikari.GuildChannelEvent.get_channel()
  • hikari.GuildMessageCreateEvent.get_channel(), hikari.GuildMessageUpdateEvent.get_channel(), hikari.GuildMessageDeleteEvent.get_channel() (not sure about these, but they use cache.get_guild_channel which returns a PermissibleGuildChannel)
  • hikari.GuildTypingEvent.get_channel()

Le0Developer avatar Apr 27 '22 17:04 Le0Developer

Apart from merge conflicts, what else is missing from this PR? I have time to work on it in the next couple of days @FasterSpeeding

davfsa avatar Jun 18 '22 21:06 davfsa

Apart from merge conflicts, what else is missing from this PR? I have time to work on it in the next couple of days @FasterSpeeding

I'm also up for finishing this PR. The state of this PR is not looking good right now.

mrsrmn avatar Jul 14 '22 11:07 mrsrmn

I think we probably need an implementation of Forum Channels which would be based upon this PR later. However, Discord says it's still being documented.

GoogolGenius avatar Jul 15 '22 14:07 GoogolGenius

I think we probably need an implementation of Forum Channels which would be based upon this PR later. However, Discord says it's still being documented.

That can be done in a separate pr + forum channels are not fully out yet + they have breaking changes in some endpoints

davfsa avatar Jul 15 '22 15:07 davfsa

What is the current status of this PR? Just enquiring as it seems to be inactive, not sure where it's at right now.

parafoxia avatar Sep 07 '22 21:09 parafoxia

What is the current status of this PR? Just enquiring as it seems to be inactive, not sure where it's at right now.

The review needs to be resolved I think. It’s basically finished besides a couple of things

GoogolGenius avatar Sep 07 '22 22:09 GoogolGenius