hikari icon indicating copy to clipboard operation
hikari copied to clipboard

Published 20 hours ago • verified publisher icon hikari-py

Implement Stage Instances

Open null-domain opened this issue 1 year ago • 5 comments

Summary

This PR aims to finish the work made by @ashwinvin in #695, including rebasing on the most recent hikari version (at the time of writing) and bringing tests up to scratch.

Hopefully I haven't missed anything, I only had a few hours to look at this.

Checklist

  • [x] I have run nox and all the pipelines have passed.
    • With the exception of the docs pipeline, but that isn't anything to do with me :eyes:
  • [x] I have made unittests according to the code I have added/modified/deleted.

Related issues

Closes #695 Closes #602

null-domain avatar Sep 28 '23 15:09 null-domain

Docs pipeline is ~~fixed~~ partially fixed in #1722

null-domain avatar Sep 28 '23 15:09 null-domain

https://github.com/discord/discord-api-docs/pull/5687 was merged last night so I'm gonna keep this as a draft until I get a moment to add this in. I have it committed locally but haven't had the chance to test yet.

null-domain avatar Sep 29 '23 08:09 null-domain

@FasterSpeeding please review when you can :)

davfsa avatar Jan 21 '24 09:01 davfsa

@FasterSpeeding Can you review please?

null-domain avatar Apr 10 '24 11:04 null-domain

Asides from those few small things LGTM

FasterSpeeding avatar Apr 13 '24 17:04 FasterSpeeding