hikari icon indicating copy to clipboard operation
hikari copied to clipboard

Application Command Localizations

Open mrsrmn opened this issue 2 years ago • 6 comments

Summary

This PR is an implementation of Application Command Localization

Checklist

  • [X] I have run nox and all the pipelines have passed.
  • [x] I have made unittests according to the code I have added/modified/deleted.

mrsrmn avatar Apr 22 '22 19:04 mrsrmn

Btw its worth noting that, despite the fact the docs don't mention this anywhere, this is actually an unreleased feature that they only documented for a public build-override based beta and therefore might not be merged for a bit (unless @davfsa is ok with merging a public beta but they did a public beta for threads and then made breaking changes 3 months down the line so public beta for discord doesn't guarantee that they won't break stuff).

Also fun fact the build override for this has been broken by command search v2.

FasterSpeeding avatar May 03 '22 16:05 FasterSpeeding

(unless @davfsa is ok with merging a public beta but they did a public beta for threads and then made breaking changes 3 months down the line so public beta for discord doesn't guarantee that they won't break stuff).

I would like to have things stable before adding them to the lib. Will check and decide based on that

davfsa avatar May 19 '22 10:05 davfsa

I would like to have things stable before adding them to the lib. Will check and decide based on that

The idea behind with_localizations is to not waste resources if you dont want the whole information (ie, just discovering what commands are available). I would maybe even add it as an argument to disable if people want it to

ref https://github.com/discord/discord-api-docs/pull/4653#discussion_r830352781

davfsa avatar May 22 '22 12:05 davfsa

I would maybe even add it as an argument to disable if people want it to

Thats what I originally did. I changed it to always True after a change request.

mrsrmn avatar May 22 '22 12:05 mrsrmn

As I understand, for finish this PR, someone just need use black on it, and fix docstring?

PerchunPak avatar May 30 '22 16:05 PerchunPak

As I understand, for finish this PR, someone just need use black on it, and fix docstring?

It needs to at least be approved by the maintainers of hikari too.

GoogolGenius avatar May 30 '22 17:05 GoogolGenius