hikari icon indicating copy to clipboard operation
hikari copied to clipboard

Implement modals

Open thesadru opened this issue 3 years ago • 7 comments

References

Checklist

ETA: 2 months ago

  • [x] Make all pipelines pass
  • [x] modal interaction response (sent to user)
    • [x] builder
    • [x] rest method
  • [x] modal interaction event (gotten from user)
    • [x] all attributes
    • [x] all helper methods
    • [x] respond with rest
    • [x] respond with restbot
  • [x] text input
    • [x] interaction model
    • [x] response builder
      • [x] builder classes
      • [x] helper methods
  • [x] factory
    • [x] modal
    • [x] text input
  • [x] tests
    • [x] modal interaction response
      • [x] rest
      • [x] helper methods
    • [x] modal interaction response builder
      • [x] rest
      • [x] helper methods
    • [x] modal interaction event
      • [x] entity factory
      • [x] methods
    • [x] text input builder
  • [ ] suggestions
    • [ ] helper method to add a single text input wrapped in an action row

thesadru avatar Feb 04 '22 11:02 thesadru

Been testing it for about a week now, seems ready for final review.

hypergonial avatar Feb 27 '22 15:02 hypergonial

An issue with adding create_modal_response to MessageResponseMixin - you cannot respond to a modal with another modal so this gives incorrect suggestions for IDE autocomplete.

thomm-o avatar Mar 25 '22 12:03 thomm-o

Is it possible to get multiline text input via a slash command in hikari or are these modals the only 'new and approved' (i.e. not traditional prefix command-based) option available?

tameTNT avatar Jun 28 '22 22:06 tameTNT

Is it possible to get multiline text input via a slash command in hikari or are these modals the only 'new and approved' (i.e. not traditional prefix command-based) option available?

This is a discord limitation

GoogolGenius avatar Jun 28 '22 22:06 GoogolGenius

Sounds about right... 🙄

Thanks for the swift reply anyway - I'll just pray for this PR to be merged soon then 🙏

tameTNT avatar Jun 28 '22 22:06 tameTNT

ModalInteraction probably needs app_permissions field added.

hypergonial avatar Jun 30 '22 21:06 hypergonial

tbh ://////

thesadru avatar Sep 02 '22 18:09 thesadru

If ya could get some of ye last review thingies fixed i'da think this would be bout ready to merge

FasterSpeeding avatar Oct 28 '22 00:10 FasterSpeeding