hikari-no-yume
Girls of DOA BlackJack ~ The Kasumi Version ~
Add Support for Girls of DOA BlackJack ~ The Kasumi Version ~
Requires all changes here aand the following, which are already on GerritHub: https://review.gerrithub.io/c/touchHLE/touchHLE/+/1178098 https://review.gerrithub.io/c/touchHLE/touchHLE/+/1202226 (For completeness, I've cherry-picked these commits into this PR)
App compatibility with my changes and those above put this game at a solid 4/5 stars. The game is playable with everything working: music, sound/voice effects, and it saves data (so you keep your money, album photos, and new costumes).
This was my first time writing code in rust and using GerritHub, so I hope I did everything right. Looking forward to your review of the code changes.
UPDATE: The black bar mentioned below is fixed (and touch points are right now). See the comment below for the remaining issues.
- The game has a black bar at the top that pushes the game screen down. This also seems to result in touch points being slightly higher than you would expect.
There is 1 issue that affects gameplay
- Split Action: The only one that slightly impacts gameplay. The split action is not possible on a non-touch screen since it requires moving 2 fingers/pointers in 2 different directions. I have attempted to use mouse and controller but it does not work (or it is extremely difficult). I am not able to test if this works in touchHLE on an Android device with a touch screen.
There is 2 known issues that do not affect gameplay
-
Game Messages: Dialogs asking to confirm the purchase of a photo in the Album and the message indicating you unlocked a new costume do not show the text fully (it is cut off). Yes/Confirm/No buttons work fine.
-
In Album you can buy all the items and use 'return' to go back to the Album after each purchase, but hitting 'save' then 'Yes' does not save the image. The
UIImageWriteToSavedPhotosAlbumfunction is just stubbed to mock success. There is no real incentive to impliment this function at this time since you can just screenshot the photos or get them from the IPA file itself.
It may be an offtopic, but Galaxy on fire requires stringByExpandingTildeInPath too. But with this PR now its crashes with Panic at src/frameworks/foundation/ns_string.rs:960:5: assertion failed: !path.contains('~')
It may be an offtopic, but Galaxy on fire requires stringByExpandingTildeInPath too. But with this PR now its crashes with Panic at src/frameworks/foundation/ns_string.rs:960:5: assertion failed: !path.contains('~')
I'm not implementing this function correctly yet, just well enough for this particular game to be ok with it. Will work on correcting it soon.
@klaxons1 Updated this function to a suggestion by @ciciplusplus, and it no longer has an assert in it. You may want to try again.
It may be an offtopic, but Galaxy on fire requires stringByExpandingTildeInPath too. But with this PR now its crashes with Panic at src/frameworks/foundation/ns_string.rs:960:5: assertion failed: !path.contains('~')
I'm not implementing this function correctly yet, just well enough for this particular game to be ok with it. Will work on correcting it soon.
@klaxons1 Updated this function to a suggestion by @ciciplusplus, and it no longer has an assert in it. You may want to try again.
I think it was implemented correctly, now I get thus: Panic at src/frameworks/foundation/ns_array.rs:327:51: index out of bounds: the len is 0 but the index is 0
It may be an offtopic, but Galaxy on fire requires stringByExpandingTildeInPath too. But with this PR now its crashes with Panic at src/frameworks/foundation/ns_string.rs:960:5: assertion failed: !path.contains('~')
I'm not implementing this function correctly yet, just well enough for this particular game to be ok with it. Will work on correcting it soon. @klaxons1 Updated this function to a suggestion by @ciciplusplus, and it no longer has an assert in it. You may want to try again.
I think it was implemented correctly, now I get thus: Panic at src/frameworks/foundation/ns_array.rs:327:51: index out of bounds: the len is 0 but the index is 0
This is a different error in an entirely different class. Don’t think it is related.
Made a few changes so that UI Bar Button Stub shows the name of the button in logs. Corrected UIToolbar so that it is a UIView, not a UIControl.
@klaxons1 I have correctly implimented the stringByExpandingTildeInPath function now and Galaxy Of Fire actually creates gof_highscores_13 gof_highscores_14 in www.fishlabs.net.GalaxyOnFire/Library/GOF (which is the folder it references as ~/Library/GOF that is now corrected by the the function) but sadly still fails in ns_array as before. This is as far as I am willing to go for this PR, but I may look further into that error in another branch.
Big progress on UIToolbar & UIBarButtonItem. it atually renders on the screen, but ths game should have a 'return' and 'save' button. Only 'return' button shows. Clicking return button does nothing. Need to figure out how to make it work.
Updated main comments.. return and save both show now and respond to clicks. However, that is about the extent of it as touchHLE now crashes when the buttons are clicked. Happening on this line: https://github.com/touchHLE/touchHLE/blob/trunk/src/frameworks/core_animation/ca_layer.rs#L476
Again updated main comments. I got the Album return button working. So, now everything is good. I await feedback to get all of this Merged.
UIImageWriteToSavedPhotosAlbum stub that fakes success is done. This game no longer crashes at any point as far as I can tell.
No!! Closed again :'(
please stop spamming here or you will be banned from the repo
