touchHLE icon indicating copy to clipboard operation
touchHLE copied to clipboard

Implement multiple functions for Spore

Open teromene opened this issue 1 year ago • 20 comments

This brings Spore version 1.0.64 to a running state.

teromene avatar Jan 31 '24 16:01 teromene

This is an interesting PR, does the game work fully for you? I have my own set of hacky patches that get Spore: Origins running, but it crashes after finishing the tutorial.

hikari-no-yume avatar Jan 31 '24 17:01 hikari-no-yume

It crashes on null-page access after modifying the creature for the first time

teromene avatar Jan 31 '24 18:01 teromene

Oh okay, so you've hit the same problem I did. I was probably using an older version of Spore: Origins that doesn't need quite as many functions.

hikari-no-yume avatar Jan 31 '24 18:01 hikari-no-yume

Hello @teromene ,

Please follow this guide https://github.com/hikari-no-yume/touchHLE/blob/trunk/CONTRIBUTING.md if you want to contribute.

In particular:

  • you should push your commits to Gerrithub with Change-Ids
  • please abide to https://github.com/hikari-no-yume/touchHLE/blob/trunk/dev-docs/code-style.md
  • please separate your PR to smaller commits. You could group them by functionality or API implementation

Thanks

ciciplusplus avatar Feb 02 '24 16:02 ciciplusplus

Done. I have submitted my changes to gerrit

teromene avatar Feb 07 '24 15:02 teromene

@teromene please email me at my git email address if you want access to the developer Discord server

ciciplusplus avatar Feb 07 '24 18:02 ciciplusplus

close pr, spore work in touchhle trunk

makaher avatar Jun 16 '24 14:06 makaher

close pr, spore work in touchhle trunk

It is not, it's crashing after a tutorial.

Please stop creating noise in the different issues/PRs, otherwise I'll ban you for a week.

ciciplusplus avatar Jun 16 '24 14:06 ciciplusplus

close pr, spore work in touchhle trunk

It is not, it's crashing after a tutorial.

Please stop creating noise in the different issues/PRs, otherwise I'll ban you for a week.

its in teromene trunk and in touchhle original trunk

makaher avatar Jun 16 '24 20:06 makaher

Please understand that only touchHLE trunk is official.

hikari-no-yume avatar Jun 16 '24 20:06 hikari-no-yume

Please understand that only touchHLE trunk is official.

In this pull request, everything is the same as in the official one, it does not develop and the game works the same as in the original touchhole

makaher avatar Jun 17 '24 00:06 makaher

Test Spore 1.0

marcosemuladores avatar Jul 29 '24 00:07 marcosemuladores