scs icon indicating copy to clipboard operation
scs copied to clipboard

Published 20 hours ago • verified publisher icon hikalkan

Implemented [local] named pipe transport support.

Open lor3 opened this issue 11 years ago • 3 comments

Not sure if you are interested in this, in my tests (Windows 8.1/64-bit) TCP connections were around 50% faster which was a bit of a surprise, but this may not be the case for older Windows versions.

Could be made into an external module if some Scs internals were made public.

Review on Reviewable

lor3 avatar Dec 23 '13 13:12 lor3

src/Scs/Communication/Scs/Communication/Channels/Pipes/NamedPipeConnectionListener.cs, line 72 [r1] (raw file): Why?

Comments from the review on Reviewable.io

lor3 avatar Jun 25 '15 09:06 lor3

👍🏻

menduz avatar Dec 08 '15 19:12 menduz

Hi,

Your effort is valuable. But I also did implemented NamedPipes as communication channel. But saw that it's slower than TCP (especially when using mutexes to control read/write to named pipe). And then I removed it since TCP is more generic and it has no resctriction to be in same computer like named pipes.

So, I think to not include named pipes to SCS. If you really like, you may publish it as a seperated library. So, anyone can add reference to your library and use it in SCS.

Thanks a lot.

hikalkan avatar Dec 28 '15 18:12 hikalkan