higlass-server icon indicating copy to clipboard operation
higlass-server copied to clipboard

get rid of test.sh

Open mccalluc opened this issue 8 years ago • 2 comments

Different tests have different setup requirements. End goal is to only have python tests and call them via manage.

mccalluc avatar Mar 01 '17 21:03 mccalluc

Can manage download files for you? I think this is the main reason for having test.sh no?

flekschas avatar Oct 30 '18 13:10 flekschas

I'm not totally against a shell wrapper for tests, particularly if there are different kinds of tests, ie, unit tests + linting + building a package, but we've only got one test run here, and the rest is setup.

I think I was imagining that the tests would have setup methods that would download the files they need. By having this nearby, it's more clear what each test needs in order to run, and it also makes it easier to use the other command-line options on the test runner.

It's sort of like global variables: If something goes wrong, it's harder to track down what should have established the state we wanted.

(But obviously this isn't critical.)

mccalluc avatar Oct 30 '18 14:10 mccalluc