scws icon indicating copy to clipboard operation
scws copied to clipboard

Published 20 hours ago • verified publisher icon hightman

Patches for _xdb_read_data and xdb_open

Open bearlin opened this issue 8 years ago • 3 comments

  1. Add some protections in _xdb_read_data
  2. In xdb_open, add O_BINARY flag for cygwin/windows

bearlin avatar Mar 07 '16 15:03 bearlin

I think we can use following code:

#ifndef O_BINARY
#define O_BINARY 0
#endif

hightman avatar Mar 08 '16 01:03 hightman

Ok, I will add this and remove the "#ifdef WIN32" around open()

bearlin avatar Mar 08 '16 09:03 bearlin

@hightman Please review and hope we can merge this PR soon.

bearlin avatar Jun 15 '22 07:06 bearlin