highlight.js icon indicating copy to clipboard operation
highlight.js copied to clipboard

add Cybertopia themes

Open noraj opened this issue 1 year ago • 4 comments

New theme with 4 variants, source here (with screenshots): https://github.com/noraj/cybertopia-highlightjs

noraj avatar Sep 30 '24 22:09 noraj

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +505 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -1 B
es/highlight.min.js 8.18 KB 8.18 KB -1 B
highlight.min.js 8.22 KB 8.22 KB -1 B

github-actions[bot] avatar Sep 30 '24 22:09 github-actions[bot]

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -1 B
es/highlight.min.js 8.18 KB 8.18 KB -1 B
highlight.min.js 8.22 KB 8.22 KB -1 B

github-actions[bot] avatar Oct 01 '24 19:10 github-actions[bot]

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change +4 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B

github-actions[bot] avatar Oct 20 '24 19:10 github-actions[bot]

I almost forgot about checkTheme.js... please run it and add the few missing styles to your theme. You can ignore the optional ones if you really want, but we'd like to see all the non-optional ones to include new themes here.

I'll also try to find the time to fix the accessibiltiy checks to work with variables - since we also care about the accessibility of our themes out of the box.

joshgoebel avatar Oct 20 '24 19:10 joshgoebel

Great suggestion, I'll run checkTheme.js as asked in theme-guide and add the missing styles.

For accessibility, I checked the contrast against WCAG at https://webaim.org/resources/contrastchecker/.

noraj avatar Oct 29 '24 21:10 noraj

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

2 files changed

Total change +2 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B

github-actions[bot] avatar Oct 30 '24 01:10 github-actions[bot]

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +548 B
styles/cybertopia-dimmer.min.css +565 B
styles/cybertopia-icecap.min.css +551 B
styles/cybertopia-saturated.min.css +567 B

3 files changed

Total change +3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B

github-actions[bot] avatar Oct 30 '24 01:10 github-actions[bot]

Could you please rebase to resolve conflicts?

joshgoebel avatar Oct 31 '24 21:10 joshgoebel

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +548 B
styles/cybertopia-dimmer.min.css +565 B
styles/cybertopia-icecap.min.css +551 B
styles/cybertopia-saturated.min.css +567 B

3 files changed

Total change -8 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -3 B
es/highlight.min.js 8.18 KB 8.18 KB -3 B
highlight.min.js 8.22 KB 8.22 KB -2 B

github-actions[bot] avatar Oct 31 '24 21:10 github-actions[bot]

Boom. Merged! Thanks so much.

joshgoebel avatar Oct 31 '24 21:10 joshgoebel

Thank you for the guidance.

noraj avatar Oct 31 '24 22:10 noraj