fix(php) improves attribute highlighting
Fixes #4115.
Changes
- Support uppercase names inside PHP attribute blocks
Checklist
- [ ] Added markup tests, or they don't apply here because...
- [ ] Updated the changelog at
CHANGES.md
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
2 files changed
Total change +36 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/languages/php.min.js | 2.62 KB | 2.64 KB | +18 B |
| languages/php.min.js | 2.63 KB | 2.64 KB | +18 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +55 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | -3 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | -3 B |
| es/languages/php.min.js | 2.62 KB | 2.65 KB | +31 B |
| highlight.min.js | 8.22 KB | 8.22 KB | -1 B |
| languages/php.min.js | 2.63 KB | 2.66 KB | +31 B |
Just needs a changes entry and rebase.
And maybe change one of the attributes to uppercase inside of test. #[ASSERT(value: 1234)]
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +56 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | -2 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | -2 B |
| es/languages/php.min.js | 2.62 KB | 2.65 KB | +31 B |
| highlight.min.js | 8.22 KB | 8.22 KB | -2 B |
| languages/php.min.js | 2.63 KB | 2.66 KB | +31 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
4 files changed
Total change +60 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | -1 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | -1 B |
| es/languages/php.min.js | 2.62 KB | 2.65 KB | +31 B |
| languages/php.min.js | 2.63 KB | 2.66 KB | +31 B |