node-export-server icon indicating copy to clipboard operation
node-export-server copied to clipboard

cleanup/colors-package-removal

Open jszuminski opened this issue 1 year ago • 4 comments

What and why?

The goal of this pull request is to get rid of the unnecessary colors dependency and perform a slight refactoring of the logging logic. The logging statements (even the longer ones) were shared across multiple files even though they have been exactly the same. If someone wanted to modify them in the future, he or she would have to modify 8 files (which might get tricky).

Tasks

  • [x] remove colors package
  • [x] replace all its appearances with our custom logging colors
  • [x] add this change to changelog
  • [ ] slight cleaning of the logger.js and most console log statements

jszuminski avatar Jul 16 '24 13:07 jszuminski

@PaulDalek what do you think about this type of defining colors and styles? Is it okay here in this use case or should we handle them differently?

jszuminski avatar Jul 16 '24 13:07 jszuminski

Thanks @bvogel! Great suggestions, all applied.

jszuminski avatar Jul 17 '24 07:07 jszuminski

Glad you liked them, hopefully this get's merged and released soon!

bvogel avatar Jul 18 '24 14:07 bvogel

too bad, didn't make it into 4.0.0

bvogel avatar Aug 05 '24 09:08 bvogel