enhancement/pictorial-series

[magdalena-gut]

trafficstars

Pictorial series in progress.

TO DO:

• [x] - test drilldown - drilldown is not working properly: http://jsfiddle.net/BlackLabel/z9y8fgc7/,

• [x] - shape disappear after hover https://jsfiddle.net/BlackLabel/jqe83rwc/

• [x] - add tests to hover,

• [x] - animate height/width instead of scale,

• [x] - border/shadow for null points, plus sample.

• [x] - check update stackBorder,

• [x] - preserving aspect ratio by default,

• [x] - stroke to the different value (not 1)

• [x] - inverted animation,

• [x] - stackShadow independent rendering,

• [x] - stackShadow should works when yAxis visible to false

• [x] - implement path.max

• [x] - animate drilldown,

• [x] -animated from legend

• [x] - refactoring: add fill to variable 'patternFill', check duplicated code

• [x] - create official demo,

• [x] - check API

• [x] - add path.max demo

• [x] - stackShadow demo

• [ ] - documentation page,

• [ ] - edit demos readme, descriptions and accecibility

ENHANCEMENTS:

• [ ] - change the path to URL (dedicated method or tutorial on how to make svg in gimp)

[highsoft-bot]

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

	master	candidate	difference
highcharts.js	100.0 kB 296.5 kB	100.1 kB 296.6 kB	116 B 85 B
highstock.js	132.8 kB 401.6 kB	132.9 kB 401.7 kB	88 B 91 B
highmaps.js	126.2 kB 382.9 kB	126.1 kB 383.0 kB	-124 B 85 B
highcharts-gantt.js	135.5 kB 406.3 kB	136.0 kB 406.4 kB	427 B 87 B

[highsoft-bot]

Visual test results - No difference found

---

Samples changed

Change type	Sample
Modified	samples/highcharts/demo/pictorial-stackshadow/demo.js
Added	samples/highcharts/series-pictorial/inverted/demo.js
?	samples/highcharts/yaxis/stackshadow/demo.js
Modified	samples/highcharts/yaxis/stackshadow/demo.js
Modified	samples/highcharts/series-pictorial/paths-max/demo.js
Modified	samples/highcharts/demo/pictorial/demo.js
Modified	samples/highcharts/series-pictorial/paths-max/demo.js
Modified	samples/highcharts/yaxis/stackshadow/demo.js
Deleted	samples/highcharts/studies/pictorial/demo.js
Modified	samples/highcharts/demo/pictorial/demo.js
Modified	samples/highcharts/series-pictorial/paths-max/demo.js
Modified	samples/highcharts/yaxis/stackshadow/demo.js
Modified	samples/highcharts/series-pictorial/paths-max/demo.js
Modified	samples/highcharts/demo/pictorial/demo.js
Modified	samples/highcharts/demo/pictorial/demo.js
Added	samples/highcharts/series-pictorial/paths-max/demo.js
Added	samples/highcharts/yaxis/stackshadow/demo.js
Added	samples/highcharts/demo/pictorial/demo.js
Modified	samples/highcharts/studies/pictorial/demo.js
Modified	samples/highcharts/studies/pictorial/demo.js
Modified	samples/highcharts/studies/pictorial/demo.js

[magdalena-gut]

Drilldown is not working properly:

Demo: http://jsfiddle.net/BlackLabel/jfpse9t3/

[Izothep]

@TorsteinHonsi it looks that mentioned issue with StackShadow duplication is caused by the latest change on the master branch, inside the Axis.ts file

if (stacking) {
                // #17314 clear stacks before new build
                stacking.cleanStacks();
                stacking.buildStacks();
}

stacking.cleanStacks() is cleaning stacks, but we are not destroying the stackShadow in between. That is causing a situation when we still have the graphic, but no reference inside the stackItem.

@pawelfus Unfortunately, I had some problems recreating your issue on my end.

[TorsteinHonsi]

@Izothep Okay, thanks! We also have another regression with the same commit - it now fails to remove stack labels on redraw. So the same symptom, the stacks are removed but not properly destroyed. I will look into it.

[pawelfus]

@Izothep I confirm, it's no longer an issue. I guess cache or I forgot to build the package, I'm sorry!

[TorsteinHonsi]

@Izothep The stack labels bug is fixed on master now, I expect this to resolve the orphaned stack shadow bug too.

[magdalena-gut]

Merged master into a branch - stack shadow looks good now!