highcharts-editor icon indicating copy to clipboard operation
highcharts-editor copied to clipboard

Change meta for border radius to have a min=0

Open cvasseng opened this issue 8 years ago • 6 comments

cvasseng avatar Sep 07 '16 07:09 cvasseng

Note that this was actually caused by number types not taking min/max into consideration. Once that was added, it worked as the meta from the chart cloud already had these properties for border width (and others).

However, I will be adding min/max/step to the API docs themselves also to limit the amount of configuration data required in the editor-specific meta.

cvasseng avatar Sep 09 '16 08:09 cvasseng

When adding this to the database docs, perhaps it is a good idea to nest them in an editor object so we don't pollute the basic documents?

[...]
"fullname": "chart.borderWidth",
"editor": {
  "min": 0,
  "step": 1,
  "max": 20
},
[...]

TorsteinHonsi avatar Sep 09 '16 08:09 TorsteinHonsi

Yeah, I think that's a good idea. Maybe call it something else than editor though to make it more general? meta or something? I don't know.

cvasseng avatar Sep 09 '16 10:09 cvasseng

Yes, unless meta is too general :) But I think it's a fair point, we may want to use these props for other things than an editor GUI. Currently the use case is the Cloud, the Editor and third party editors like Highcharts GWT and EasyCharts.

TorsteinHonsi avatar Sep 12 '16 08:09 TorsteinHonsi

constraints would perhaps work for these types of properties, but there may be others we want to include too that aren't "constraints"..

It's like they say; there are only two difficult things in computer science - naming things and cache invalidation..

cvasseng avatar Sep 12 '16 12:09 cvasseng

Yes, like constraints.friendlyTooltipTextForNonTechies :)

TorsteinHonsi avatar Sep 12 '16 13:09 TorsteinHonsi