mosh icon indicating copy to clipboard operation
mosh copied to clipboard

mac/FreeBSD: Still needs `GC_DONT_GC` on bootstrap

Open okuoku opened this issue 2 years ago • 4 comments

With https://github.com/higepon/mosh/commit/c80908f2186b5d4cfcf97c56b78fb715e14b0e82 +

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 893e44b3..8ee23bd1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -165,8 +165,6 @@ jobs:
           echo "STABLE_MOSH_PATH=${{ env.mosh_stable }}" >> $GITHUB_ENV
           echo "NATURAL_DOCS_PATH=~/NaturalDocs-1.4" >> $GITHUB_ENV
           echo "R6RS_DOC_PATH=r6rs" >> $GITHUB_ENV
-          # FIXME: Disable GC during CI for now
-          echo "GC_DONT_GC=1" >> $GITHUB_ENV
       - name: Instlall tools
         run: |
           brew install gmp oniguruma automake re2c bison gauche unzip

https://github.com/okuoku/mosh/actions/runs/3110497831/jobs/5041743580

It seems we still need GC_DONT_GC to make bootstrap succeeded.

How to reproduce

  1. Extract dist archive mosh-0.2.8-rc4.tar.gz
  2. Build it (no need to install)
  3. cd boot/runtimes/srfi-mosh
  4. ../../../mosh -5 bootstrap.vanilla-mosh/phase0.vanilla-mosh.scm
  5. ../../../mosh bootstrap.psyntax-mosh/phase1.psyntax-mosh.ss
  6. ../../../mosh -5 bootstrap.vanilla-mosh/phase2.scm → ★ Crashes here

OS/Platform

At: https://github.com/higepon/mosh/commit/365c2862687b2685fc2437977e6a5e951dc37ab5

  • Cygwin64(--disable-profiler): Do not reproduce
  • Ubuntu AMD64: Do not reproduce
  • Win64: (Cannot run bootstrap process with CMake build)
  • FreeBSD AMD64: ★ Reproduce

okuoku avatar Sep 23 '22 05:09 okuoku

Blocker #131 and #133 is now being resolved so now I can research using macOS AMD64 and FreeBSD AMD64.

My current best guess is we still have truncation issue for pointers so GC cannot correctly keep track of references. I'll chase #112 on these platforms.

okuoku avatar Sep 23 '22 20:09 okuoku

Sounds good. Let me know if there's anything I can help.

higepon avatar Sep 24 '22 00:09 higepon

On FreeBSD, still no luck with https://github.com/higepon/mosh/commit/3dd4797c1caa7a474d6c5b8ebe7d767edb6c5a6a

okuoku avatar Oct 02 '22 14:10 okuoku

Thanks for confirming!

higepon avatar Oct 02 '22 22:10 higepon